Showing posts with label Programming Skills. Show all posts
Showing posts with label Programming Skills. Show all posts

Sunday, 3 November 2013

Finally's block case against thread and daemon

Thread vs Daemon
There is a fundamental difference between JVM thread and daemon. The easiest way to see it, is by reading Oracle's documentation regarding method setDaemon in Thread class. Let's see what JavaDoc says:
" (setDaemon method) Marks this thread as either a daemon thread or a user thread. The Java Virtual Machine exits when the only threads running are all daemon threads."

I guess is pretty obvious. When there are no 'user threads' or simply threads, spawned by a given JVM, JVM exits. 

Finally block
However there is one more gotcha there. It is the problem of finally block execution. Now, let's analyze Oracle's documentation devoted to finally block:
"The finally block always executes when the try block exits. This ensures that the finally block is executed even if an unexpected exception occurs. But finally is useful for more than just exception handling — it allows the programmer to avoid having cleanup code accidentally bypassed by a returncontinue, or break. Putting cleanup code in a finally block is always a good practice, even when no exceptions are anticipated."

Just below that general definition, there is an interesting note:
"Note: If the JVM exits while the try or catch code is being executed, then the finally block may not execute. Likewise, if the thread executing the try or catch code is interrupted or killed, the finally block may not execute even though the application as a whole continues."

Nice. I think, I am getting slightly confused, now. Moreover, Oracle gives another important note, at the end of the page, saying that finally block prevents from resource leaks: 
"Important: The finally block is a key tool for preventing resource leaks. When closing a file or otherwise recovering resources, place the code in a finally block to ensure that resource is always recovered."

Question
So my question is, how finally block behaves, when daemon and thread are interrupted?

Experiment
I prepared two, fairly simple examples. There is a SampleProcess class, which is intended to be run in background i.e. that is what newly spawned thread or daemon will do. It will be kicked off by the ProcessLauncher object from either ThreadRunner or DaemonRunner runner classes.

package common;

public class SampleProcess {

 public void start() {
  try {
   System.out.println("Sample process is going to sleep.");
   sleep(5000);
  } finally {
   sleep(1500);
   System.out.println("Sample process is running finally block.");
  }
 }

 private void sleep(long timeToSleep) {
  try {
   Thread.sleep(timeToSleep);
  } catch (InterruptedException e1) {
   System.out.println("Sample process is running catch block for time to sleep = " + timeToSleep);
  }
 }
}
package common;

public class ProcessLauncher {

 public void launchAsThread() {
  this.launch("Thread", false);
 }

 public void launchAsDaemon() {
  this.launch("Daemon", true);
 }

 private void launch(String processName, boolean isDaemon) {

  Thread process = new Thread(){

   @Override
   public void run() {
    new SampleProcess().start();
   }
  };
  process.setDaemon(isDaemon);
  process.start();
  System.out.println(processName + " runner is going to interrupt sample process.");
  process.interrupt();
 }
}
package daemon;

import common.ProcessLauncher;

public class DaemonRunner {

 public static void main(String[] args) {
  new ProcessLauncher().launchAsDaemon();
 }
}
package thread;

import common.ProcessLauncher;

public class ThreadRunner {

 public static void main(String[] args) {
  new ProcessLauncher().launchAsThread();
 }
}

Results
And here are results for thread and daemon, respectively:
Thread runner is going to interrupt sample process.
Sample process is going to sleep.
Sample process is running catch block for time to sleep = 5000
Sample process is running finally block.

Process finished with exit code 0
Daemon runner is going to interrupt sample process.
Sample process is going to sleep.
Sample process is running catch block for time to sleep = 5000

Process finished with exit code 0

Conclusion
The important conclusion is fact that daemon processes are somewhat unsafe and misleading. They DO NOT ALWAYS run finally block, which prevents us from resource leaks. So, when JVM halts, it only waits for 'user threads' to be finished. Any remaining daemon threads are simply stopped. Finally blocks are not run - JVM just stops.



That is why, daemon threads should be used with at most care and prudence. Also, bear in mind that using daemons for tasks related to resource management (I/O) is walking on a thin ice.

You can find entire example on my GitHub account.

Sunday, 11 August 2013

Wrestling with Singleton (Logger) - round 3

Singletons have many faces. One of them is logging mechanism. Before we start having a deeper look into entire case, let's go straight away to a simple example, to set some context.
package com.korczak.oskar.refactoring.singleton.logger.before;

import com.korczak.oskar.refactoring.singleton.logger.Engine;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;

import static org.mockito.Mockito.verify;
import static org.mockito.MockitoAnnotations.initMocks;

@RunWith(MockitoJUnitRunner.class)
public class CarTest {

 @Mock private Engine engine;
 @InjectMocks private Car car;

 @BeforeMethod
 public void setUp() {
  initMocks(this);
 }

 @Test
 public void shouldRunEngine() {
  car.start();

  verify(engine).run();
 }

 @Test
 public void shouldStopEngine() {
  car.stop();

  verify(engine).stop();
 }
}
package com.korczak.oskar.refactoring.singleton.logger.before;

import com.korczak.oskar.refactoring.singleton.logger.Engine;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class Car {

 private Logger carLogger = LoggerFactory.getLogger(Car.class);

 private Engine engine;

 public Car(Engine engine){
  this.engine = engine;
 }

 public void start(){
  engine.run();
  carLogger.info("Engine is running.");
 }

 public void stop(){
  engine.stop();
  carLogger.info("Engine is stopped.");
 }
}
We can also assume that above snippet is actually a part of, so called, fairly decent application, which is logging everything everywhere, so to speak.

What can you tell about such an application?
Is there anything particular, which is stemming out from our imaginary application?
It may look like to somewhat silly task, but unfortunately it has very deep implications, in terms of design, solving production issues, sometimes performance, overall usage and approach. It is quite a few things tangled to logging, as such.

First of all, let's decompose above snippet with attention to some basic facts:
  • Static logger is a singleton
  • Breach of unit test definition i.e. system under test is writing to file/console
  • Lack of readability to some extent
  • A bit of noise in business logic
Now, let's discuss above points a bit further and infer some more, useful information.




Logger is a Singleton
Logger is created via static call and a Singleton is returned. However, it is not that bad, as we are only writing to Singleton and never reading from it. It means we are not exploiting a global state introduced in our JVM by Singleton. On the other hand, it is worth bearing in mind that static call means no seams. There are two direct implications of that: 
  • untested production code, as there are no seams
  • message will be logged anyway during running tests

Unit test definition breach
That is how we came to the second fact related to unit tests.
Michael Feathers defines unit tests as: 

A test is not a unit test if:

  • It talks to the database
  • It communicates across the network
  • It touches the file system
  • It can't run at the same time as any of your other unit tests
  • You have to do special things to your environment (such as editing config files) to run it.

  • I suppose we can agree that above test is an integration one, rather then a unit sort of thing. Feathers's definition sticks to what people understand under unit test term. 
    Why don't we finally admit that so called unit tests, which are logging information to a file/console whatever, are in fact a decent integration tests. Full stop.

    What is the business related reason?
    Going further one can focus on a business reason in that whole tangled situation and answer a question: is there any business related reason to log particular information in particular place?
    The most common answer would be that by logging we mean sending a message from application to whoever is browsing logs. Usually, it would be two main groups of recipients: L1/L2 and L3/testes/developers teams. 
    L1/L2 guys would like to see only nasty things happening in a given application e.g. errors, alerts and perhaps warnings. On the other hand, L3/testers/developers would like to see a bit more i.e. states generated by application during its processing etc. It is worth reiterating that none of them is a business person.

    When we dig a bit deeper and ask what is the underlying principle of logging, we will probably come to below two points:
    • log a state of processed unit
    • say 'I was here' or 'I have chosen that path in you application logic'
    Above things tell us where we are and are often called diagnostic reasons/purposes. They share a common feature that none of them is driven by any business requirement. Let's be honest, business people are not reading logs. They can only read spreadsheets, but you probably know that already, I suppose.

    Readability and noise
    Unfortunately, logging affects a bit negatively the overall readability of business logic. It adds additional noise and clutters codebase, when it is overused.

    How it might be done?
    The easiest might be to imagine an event driven system, where an event comes in, it is being processed and some final response is sent. As it was pointed, logging would be used for diagnostic purposes. If yes, I am questioning the logger usage, almost at all. Why don't we change our applications design so that it can monitor, diagnose and track the state of all, incoming events itself? 
    I already can hear answers: 'it is too much effort', 'we don't need it' or better one 'our project is different'. ;)
    Partially, it might be true and I agree it is pointless, in some trivial cases, to build errors aware applications for your younger sister's diary application, although still it is worth at least considering it in some larger projects. 
    Also, don't get me wrong, if there is a clear business drive for having something logged, just do it. The only thing I am asking to remember is fact that logging is a sort of contract between application and whoever is reading logs. If there is a business need for having some log entry, simply test it. 

    When you have self aware system in place and an issue occurs, you may ask your application for some useful 'diagnostic information' (including states) on demand via say REST API or whatever. 

    Implementing that sort of approach is in fact a win-win situation for all project stakeholders. Not only L3 and developers are able to deal with errors in processing, but also testers, L1, L2 teams are able to do that. Even BAs start analyzing and solving some burning questions themselves. 
    In a long run, it is less work for busy developers, everybody can leverage and use diagnostic information. What's even more important, the knowledge and the responsibility is shared across entire team/stakeholders. It only requires two things: 
    1. Stop logging everything in the log files
    2. Add sort of issues memory or events state memory to your system
    The first step here is to start testing logging in your applications. Try to make logger a collaborator of your class, not a static call and use it where it is really necessary. 
    Testing logging enforces thinking about every single message, which might be potentially logged. Additional effort spent on writing test for logger, should actually drive aware developer through all above concerns, helping to understand the business reason behind particular piece of code.
    package com.korczak.oskar.refactoring.singleton.logger.after;
    
    import com.korczak.oskar.refactoring.singleton.logger.Engine;
    import org.junit.runner.RunWith;
    import org.mockito.ArgumentCaptor;
    import org.mockito.Captor;
    import org.mockito.InjectMocks;
    import org.mockito.Mock;
    import org.mockito.runners.MockitoJUnitRunner;
    import org.slf4j.Logger;
    import org.testng.annotations.BeforeMethod;
    import org.testng.annotations.Test;
    
    import static org.mockito.Mockito.verify;
    import static org.mockito.MockitoAnnotations.initMocks;
    import static org.testng.AssertJUnit.assertEquals;
    
    @RunWith(MockitoJUnitRunner.class)
    public class DecentCarTest {
    
     @Mock private Engine engine;
     @Mock private Logger decentCarLogger;
     @InjectMocks private DecentCar decentCar;
    
     @Captor private ArgumentCaptor argument;
    
     @BeforeMethod
     public void initializeMocks() {
      initMocks(this);
      argument = ArgumentCaptor.forClass(String.class);
     }
    
     @Test
     public void shouldRunEngineAndLogMessage() {
      decentCar.start();
    
      verify(engine).run();
      verify(decentCarLogger).info(argument.capture());
      assertEquals("Engine is running.", argument.getValue());
     }
    
     @Test
     public void shouldStopEngineAndLogMessage() {
      decentCar.stop();
    
      verify(engine).stop();
      verify(decentCarLogger).info(argument.capture());
      assertEquals("Engine is stopped.", argument.getValue());
     }
    }
    
    package com.korczak.oskar.refactoring.singleton.logger.after;
    
    import com.korczak.oskar.refactoring.singleton.logger.Engine;
    import org.slf4j.Logger;
    
    public class DecentCar {
    
     private Engine engine;
     private Logger decentCarLogger;
    
     public DecentCar(Engine engine, Logger decentCarLogger){
      this.engine = engine;
      this.decentCarLogger = decentCarLogger;
     }
    
     public void start(){
      engine.run();
      decentCarLogger.info("Engine is running.");
     }
    
     public void stop(){
      engine.stop();
      decentCarLogger.info("Engine is stopped.");
     }
    }
    

    You can find entire example on my GitHub account.

    Round three is finished.

    Friday, 21 June 2013

    Wrestling with Singleton - round 2

    Here comes the time for round 2 of our fight with Singleton. This time, we will try to get rid off unwanted, hard-wired dependency, by applying Michael Feathers's trick. 



    During first round, we used a simple, wrapping mechanism, enabling developer to disjoin Singleton from class under test. Although it is not complicated, it does amend production code in few places. What Michael Feathers has suggested in his book "Working Effectively with Legacy Code", is a slightly different approach. It also does changes in production code, but just in Singleton class itself. One may say it is a less invasive way of dealing with that sort of problem.
    Anyway, let's get started in the same place, we started last time:

    public class PropertiesCache {
    
     private static PropertiesCache instance = new PropertiesCache();
    
     private PropertiesCache() {
    
     }
    
     public static PropertiesCache getInstance() {
      return instance;
     }
    
     public boolean overrideWith(File fileProperties) {
      return someWeirdComplicatedFilePropertiesLogic(fileProperties);
     }
    
     private boolean someWeirdComplicatedFilePropertiesLogic(File fileProperties) {
      if (fileProperties.length() % 2 == 0) {
       return true;
      }
      return false;
     }
    }
    
    public class SamplePropertiesCacheUsage {
    
     public boolean overrideExistingCachePropertiesWith(File fileProperties){
      PropertiesCache cachedProperties = PropertiesCache.getInstance();
      return cachedProperties.overrideWith(fileProperties);
     }
    }
    I added a static setter to PropertiesCache class using InteliJ tool called: code - generate setter. Second move is a manual change of constructor's modifier: from private to protected.
    public class PropertiesCache {
    
     private static PropertiesCache instance = new PropertiesCache();
    
     protected PropertiesCache() {
    
     }
    
     public static PropertiesCache getInstance() {
      return instance;
     }
    
     public static void setInstance(PropertiesCache instance) {
      PropertiesCache.instance = instance;
     }
    
     public boolean overrideWith(File fileProperties) {
      return someWeirdComplicatedFilePropertiesLogic(fileProperties);
     }
    
     private boolean someWeirdComplicatedFilePropertiesLogic(File fileProperties) {
      if (fileProperties.length() % 2 == 0) {
       return true;
      }
      return false;
     }
    }
    
    Now, I created two classes inheriting from the Singleton. They stub the overrideWith method. As you can see, there is also a simple, but valuable test created.
    public class StubbedForTruePropertiesCache extends PropertiesCache {
    
     @Override
     public boolean overrideWith(File fileProperties) {
      return true;
     }
    }
    
    public class StubbedForFalsePropertiesCache extends PropertiesCache {
    
     @Override
     public boolean overrideWith(File fileProperties) {
      return false;
     }
    }
    
    public class SamplePropertiesCacheUsageTest {
    
     private File dummyFileProperties;
     private SamplePropertiesCacheUsage propertiesCache;
    
     @BeforeMethod
     public void setUp() {
      dummyFileProperties = new File("");
      propertiesCache = new SamplePropertiesCacheUsage();
     }
    
     @Test
     public void shouldReturnTrueDueToWeirdInternalSingletonLogic() {
      PropertiesCache.setInstance(new StubbedForTruePropertiesCache());
    
      boolean result = propertiesCache.overrideExistingCachePropertiesWith(dummyFileProperties);
    
      assertThat(result, is(equalTo(TRUE)));
     }
    
     @Test
     public void shouldReturnFalseDueToWeirdInternalSingletonLogic() {
      PropertiesCache.setInstance(new StubbedForFalsePropertiesCache());
    
      boolean result = propertiesCache.overrideExistingCachePropertiesWith(dummyFileProperties);
    
      assertThat(result, is(equalTo(FALSE)));
     }
    }
    That's all. We have relaxed the coupling between Singleton and system under test. We have tests. Design is also improved a bit. We reached our goal.

    As previously, you can find entire refactoring exercise on my GitHub account.

    Round two is finished.

    Sunday, 26 May 2013

    Wrestling with Singleton - Round 1

    How many times you were dealing with Singletons in your codebase. To be frank, it has been always a problem to properly understand the nature of Singleton, its usage and refactoring methods. Singleton, as such is not an embodied evil. It is rather the usage that developers think they "design". 

    In order to fully understand the problem, let's have a quick look on Gang of Four (GoF) Singleton definition:
    "Ensure a class only has one instance, and provide a global point of access to it.". 
    The big hoo-ha is focusing on second part of above definition: "... providing a global point of access to it (to a single object).". In GoF's implementation, they provided a global point of access, by taking the advantage of static getInstance() method. While it perfectly well fulfills assumptions and leading concept of Singleton definition, it also introduces "an extra, unwanted feature" i.e. a global state visible to every class. 

    Well, some pesky guy, with devil-may-care attitude may say, so what! Apparently nothing, however I can bet that such a smart alec has never written a single line of unit test, especially in legacy code. The thing is people invented Singleton pattern to maintain a single instance of the object among the entire set of object graphs aka an application. Providing a global access point in a correct way is slightly more tricky to materialize, than just using static getInstance() method. However, it is still feasible to do it in a right way.

    Have you ever thought, why nobody finds faults with Spring or with any other Dependency Injection (DI) framework? People do not moan about DIs libraries, even though there is a way to make an object a singleton. Now, it sounds odd! In fact, the answer is hidden in lowercase singleton. Spring is able to create, maintain and inject a singleton object, without exposing it as a global state. It is worth to notice that Spring deals with Singleton problem, correctly. It not only meets GoFs definition without adding any unnecessary burden i.e. no static getInstance() method, but also provides desired inversion of control. It is an xml configuration, which is enabling us to mark a bean as a singleton and that is it. If you want to use it, you will have to inject it, as any other bean via constructor, setter or field. DI framework, in its construction, promotes testability by enforcing the concept of seam.

    If you are a bit nosy person, you should ask this sort of question: is it the only, correct way I can use singletons? Obviously, the answer is: no, it is not. The reason why DI framework makes better use of singletons is the fact that it combines single instance of some class with dependency injection.
    If you do not want to use Spring for some reason or it is simply an overkill for your solution, then there are at least two ways you can choose. You can either use the 'wrap the Singleton' or 'inherit from singleton' approach. In this article, I will focus on the former one. In a nutshell, it is a dependency injection for poor man going along with Singleton. Incidentally, it is quite powerful technique, when it comes to legacy code refactoringLet's have a look on a model GoF's implementation of Singleton pattern and its usage in sample legacy code: 


     
       public class PropertiesCache {
    
    	private static PropertiesCache instance = new PropertiesCache();
    
    	private PropertiesCache() {
    
    	}
    
    	public static PropertiesCache getInstance() {
    		return instance;
    	}
    
    	public void overrideWith(File fileProperties) {
    		// some logic comes here
    	}
     }
    
     
    public class SamplePropertiesCacheUsage {
    
    	public void overrideExistingCachePropertiesWith(File fileProperties){
    		PropertiesCache cachedProperties = PropertiesCache.getInstance();
    		cachedProperties.overrideWith(fileProperties);
    	}
    }
    

    It is a very simple and extremely common scenario, which shows the tight coupling between SamplePropertiesCacheUsage and Singleton classes. Bear in mind that Singleton might be quite substantial in size, as it is a properties cache, all in all. Moreover, some cunning developer before you, might have armed Singleton with quite a few "handy methods" for loading properties from file, merging them from different sources applying precedence policies on a top of that etc. Generally speaking, nothing pleasant and it is you, who have to wrestle with that code, now.



    Let's assume that our goal is to get rid off that tight dependency to Singleton. Second, more implicit assumption is that our IDE will slightly change Singleton call in our production code.

    Okay, let's get started. First thing we should do is to look for test for SamplePropertiesCacheUsage. Wait a second, but we are going to start our digging in legacy code, so do not even bother to look for any test. It might have been quite difficult to write such test for developer, anyway. As a matter of fact, we quickly found that we have to refactor using IDE's built in methods.

    In my InteliJ IDE it will be a few steps process. First of all, let's extract a private method called getInstance(), encapsulating Singleton static call. This method is not static, any more.
     
    public class SamplePropertiesCacheUsage {
    
    	public void overrideExistingCachePropertiesWith(File fileProperties){
    		PropertiesCache cachedProperties = getInstance();
    		cachedProperties.overrideWith(fileProperties);
    	}
    
    	private PropertiesCache getInstance() {
    		return PropertiesCache.getInstance();
    	}
    }
    

    Our next step will be to extract a PropertiesCacheWrapper class with public getInstance() method, from SamplePropertiesCacheUsage Singleton client.
     
    public class SamplePropertiesCacheUsage {
    
    	private PropertiesCacheWrapper propertiesCacheWrapper = new PropertiesCacheWrapper();
    
    	public void overrideExistingCachePropertiesWith(File fileProperties){
    		PropertiesCache cachedProperties = propertiesCacheWrapper.getInstance();
    		cachedProperties.overrideWith(fileProperties);
    	}
    
    	private PropertiesCache getInstance() {
    		return propertiesCacheWrapper.getInstance();
    	}
    }
    
    
     
    public class PropertiesCacheWrapper {
    	public PropertiesCacheWrapper() {
    	}
    
    	public PropertiesCache getInstance() {
    		return PropertiesCache.getInstance();
    	}
    }

    Now, it is time for initializing propertiesCacheWrapper field in the constructor. You may also need to manually delete inlined initialization of propertiesCacheWrapper field. 
    This is actually the moment, when the injection of PropertiesCacheWrapper happens.


    public class SamplePropertiesCacheUsage {
    
    	private PropertiesCacheWrapper propertiesCacheWrapper;
    
    	public SamplePropertiesCacheUsage(PropertiesCacheWrapper aPropertiesCacheWrapper) {
    		propertiesCacheWrapper = aPropertiesCacheWrapper;
    	}
    
    	public void overrideExistingCachePropertiesWith(File fileProperties){
    		PropertiesCache cachedProperties = propertiesCacheWrapper.getInstance();
    		cachedProperties.overrideWith(fileProperties);
    	}
    
    	private PropertiesCache getInstance() {
    		return propertiesCacheWrapper.getInstance();
    	}
    }
    

    As a last step, we may delete getInstance() method from SamplePropertiesCacheUsage, as it is no longer used.
    public class SamplePropertiesCacheUsage {
    
    	private PropertiesCacheWrapper propertiesCacheWrapper;
    
    	public SamplePropertiesCacheUsage(PropertiesCacheWrapper aPropertiesCacheWrapper) {
    		propertiesCacheWrapper = aPropertiesCacheWrapper;
    	}
    
    	public void overrideExistingCachePropertiesWith(File fileProperties){
    		PropertiesCache cachedProperties = propertiesCacheWrapper.getInstance();
    		cachedProperties.overrideWith(fileProperties);
    	}
    }
    


    Let's have a look on what happened. Now, we have Singleton invocation wrapped in a separate class. What is more, SamplePropertiesCacheUsage class does have a constructor type seam, which is used to inject  PropertiesCacheWrapper. The code is now at least testable, so we are able to write a test for SamplePropertiesCacheUsage class.

    @RunWith(MockitoJUnitRunner.class)
    public class SamplePropertiesCacheUsageTest {
    
    	@Mock private PropertiesCache cachedProperties;
    	@Mock private PropertiesCacheWrapper propertiesCacheWrapper;
    	@Mock private File file;
    
    	@BeforeMethod
    	public void initializeMocks() {
    		initMocks(this);
    		given(propertiesCacheWrapper.getInstance()).willReturn(cachedProperties);
    	}
    
    	@Test
    	public void shouldOverrideExistingPropertiesWithFileProperties() {
    		SamplePropertiesCacheUsage samplePropertiesCacheUsage = new SamplePropertiesCacheUsage(propertiesCacheWrapper);
    
    		samplePropertiesCacheUsage.overrideExistingCachePropertiesWith(file);
    
    		verify(cachedProperties).overrideWith(file);
    	}
    }
    
    

    Everything looks good, now. We have a unit test describing SamplePropertiesCacheUsage class, which was previously using static call to Singleton class. We also got rid off tight dependency to Singleton. 

    You can find entire refactoring exercise on my GitHub account.

    Round one is finished.

    Tuesday, 15 January 2013

    The A Team has A players

    I think, we all know that universities' programmes do not conform well to  industry requirements. I would be even tempted to state that computer science and IT are the most vulnerable subjects, in terms of coherence between what is taught and what is required. Basically, teaching too much science can affect industry skills. What I mean is a proportion of industry to science skills (I/S). To my mind, it should be close to 1:1 proportion. In fact, we often observe much higher contribution of science, comparing to industry one. My guess, based on my private research, would be that nowadays the ratio is floating somewhere between 1:4 to 2:3.

    To be clear, I have nothing against science. I am even extremely keen on science from my childhood. What's more, I always saw a huge value in being open minded and having analytical skills. 
    On the other hand, some knowledge of current, top industry technologies, approaches and tricks is of at most importance. These are your tools. You will be using them on a daily basis. You have to know how to use them!

    Okay, rather than grumbling and ranting, let's go straight to the definition of set of requirements and skills necessary in industry. Incidentally, these might be things necessary in science, as well. 
    Below requirements were initially defined and put together by Wojtek Seliga, but then enriched in few places by me:

    Basic programming skills:
    - java.util.concurrent package
    - GC (how it works, types)
    - Socket programming and threads
    - TCP/IP, HTTP (Basic Auth, Cookies, Session)
    - Scalability - how to build scalable apps
    - Performance - how and when to pay attention for performance
    - Transactions - types of transactions
    - CAP rule

    Java Core:
    - interface, class
    - composition, inheritance
    - collections
    - complex types, algorithms
    - hash code, searching complexity, putting complexity
    - concurrency (thread, monitor, synchronization different approaches, semaphore, cyclic barrier, latch)
    - streams
    - immutability (thread safe, object pools)
    - reflection, AOP, byte code manipulation, generation, dynamic proxy - it explains how dependency injections frameworks, testing libraries work
    - Web technologies stack: Struts, Filter, Servlet, Server socket (socket bind accept)

    Libraries:
    - JDK a lot of classes, on the other hand, not so many to scroll down and eyeball check
    - Guava - very good library
    - Apache Utils
    - Yoda Time - don't use Date and Calendar
    - Spring, Nano, Pico, Guice - as dependency injection frameworks

    Tools:
    - know some IDE (keyboard shortcuts, IDE shouldn't slow you down)
    - debugger (not System.out.println all over the place)
    - profiler (bottleneck, deadlock)
    - internet traffic analyzer (WireShark, Fiddler), FireBug

    Books:
    - Effective Java 2nd edition (Joshua Bloch) - after reading you think you know everything
    - Java concurrency in practice - after reading you think you know nothing


    Personality:
    - intelligent, smart, active
    - willing to change and go out from his comfort zone
    - looks for new technologies, experience, A players are not worried to suggest something new, because even if new idea wouldn't work they learn on their own mistakes
    - they have high self esteem (often times it's correct)
    - they can often find a job
    - pragmatic
    - there is some 'public track' of them in the internet (forums, blogs, conferences, twitter etc.)


    So these are things and topics required by companies from people they are hiring. Now think, how many of these you were taught at university and how many of them you were taught and you know on a decent level. 

    Good Recruiter
    We were talking about proper set of skills for new joiner. Now let's think about person I call a good recruiter and let's analyze his approach to a candidate. A good recruiter is somebody, who is able quickly and honestly estimate the level of developer. So how they think?
    First of all, small companies pays attention for knowledge. Secondly, the most important language in IT is English. It is a sort of must be nowadays and at least good command of English is essential. The candidate should also have a correct financial self esteem and knowledge of market trends at his work. A good recruiter should also check skills, which developer will be using all the time at work i.e.:
    - naming variables and methods,
    - IDE knowledge, 
    - way of writing tests
    - refactoring

    These are things, which new developer will be coming across on a daily basis and these sort of things should be checked. Please, give me a break with intelligence tests and questions about falling bulb from the skyscraper etc. It's all pointless! Check real skills, which will be used in real life, not some artificially invented questions to show off to the recruited person.



    The best boss is the most stupid person in company
    There is also a concept of A players. Companies should hire only A and A+ players. 
    A players have rightly high self esteem. That's why the best boss is the most stupid boss, as he knows that only by hiring people better than himself, he will be able to build valuable company.
    B players are scared a bit. They don't know what other will say. They are a bit lost. B player is hiring weaker, than himself.
    C players - misery.

    People tend to blindly repeat that developer is the most precious asset of the company. 
    If yes, why companies are rising salary when precious developer is quitting?
    If developer is so important, stop your most significant project and put the best people (A and A+) to interview, because you can loose cool guy, who is waiting for his turn out there. He will pay off 100 times anyway.

    What we see in reality is that companies are sending whoever to interview new, fresh blood to the company. Is it the right move? Is it how it should be done? Definitely not.
    If company really truly believes that developer is the most important asset for them, they should use their best people to recruit others. 

    Remember: The A team has only A players.